WIP Msg filter #872
Draft
WIP Msg filter #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #872 +/- ##
===============================================
- Coverage 96.64% 96.61% -0.04%
===============================================
Files 240 241 +1
Lines 65294 65862 +568
===============================================
+ Hits 63106 63631 +525
- Misses 2188 2231 +43 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was feeling inspired on the plane, this is very much WIP and should be considered a strawman. Want to make sure we get the API and filtering right before we actually hook it up to a proposal module.
Feedback needed, hopefully the new
cw-msg-filterREADME provides a good overview of current usage and API.Hopefully Closes #694
Close this PR if someone makes a better version.